Update several dependencies to allow running on Java 11 (and also 8) #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just noting here that while a lot of our machines have access to Java 8 and Java 11 at need, some may not yet have a Java 11 available. |
|
This is mostly to be able to test on java 11, not yet to request a move away from java 8. |
|
Looks good to me. I tried it out here on mac laptop with java8 and everything is running smoothly including search api and recent additions for validation. Does make me wonder if I should change coding environment from oracle java8 to openjdk11. @balhoff let me know if/when you think that is important. |
goodb
approved these changes
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.