Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding information on the shapes that do match troublesome nodes. #270

Merged
merged 1 commit into from
Dec 18, 2019

Conversation

goodb
Copy link
Contributor

@goodb goodb commented Dec 18, 2019

No description provided.

@goodb
Copy link
Contributor Author

goodb commented Dec 18, 2019

@kltm this will add another field to the validation json object - called matched_range_shapes which will show up alongside intended_range_shapes . Its quite helpful for diagnoses..

@goodb goodb merged commit 2330cd3 into dev Dec 18, 2019
@kltm
Copy link
Member

kltm commented Dec 19, 2019

Shall we roll this out sooner rather than later?

@goodb
Copy link
Contributor Author

goodb commented Dec 19, 2019

I think at this point its more important for pretty advanced users doing batch diagnostics (user base of 1) then for Noctua users. I don't see a need to rush it forward unless you just want to test that it causes no problems.

It could have the effect of slowing things down for models failing shex validation. Basically the model is first checked for conformity (no change) and then, if bad, it will now work a little harder to build the explanation by grabbing what types exist for all of the problem nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants