Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code and test for exact match text search #310

Merged
merged 4 commits into from
Apr 25, 2020

Conversation

goodb
Copy link
Contributor

@goodb goodb commented Apr 23, 2020

No description provided.

@goodb
Copy link
Contributor Author

goodb commented Apr 24, 2020

@kltm this is failing travis because of some change to http://skyhook.berkeleybop.org/blazegraph-go-lego-with-reacto.jnl.gz
I don't have time to diagnose further till tomorrow. But.. if you are working on that, you can run the minerva build to make sure its working..

@kltm
Copy link
Member

kltm commented Apr 24, 2020

Huh. I had thought that the product of that pipeline should be correct, but I'll need to dig in. Unfortunately, I've got two other pipeline I'm working on today and might not make it.

@goodb
Copy link
Contributor Author

goodb commented Apr 25, 2020

@kltm I believe it is missing neo.owl. This was previously included in go_lego.owl and now will need to be added to the blazegraph journal in an additional step.

allow minerva to continue while pipeline details worked out...
@goodb
Copy link
Contributor Author

goodb commented Apr 25, 2020

@tmushayahama @vanaukenk FYI on current behavior here. The "exact match" here is performed only on individual tokens, not the whole title. (Sorry learning as I go here). For example when searching over the reactome models

searching like this: http://127.0.0.1:6800/search/?title=*Antigen*
results including titles containing words with antigen in them like:
Reactome:unexpanded:Cross-presentation of soluble exogenous antigens (endosomes)

searching like this: http://127.0.0.1:6800/search/?title=Antigen
will only get models where the title has the exact (ignoring case) search term like:
Reactome:unexpanded:MHC class II antigen presentation

So.. for now I suspect default to the * search with the current set up (that requires all tokens present) ought to work pretty well. If we really need true exact match search over the titles, this can be added easily.

@goodb goodb merged commit 91a8b82 into dev Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants