update master with many changes on dev #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added methods to get the root types changed how labels are gathered for ontology classes from many requests to one per model.
letting it default to old way if that is missing.
its actually a death throw before I eradicate this part of the code...
Should probably update tests like this one to better match current system.
added root-type to default m3batch response
this is mostly redundant with a test in minerva-server . Added here because it makes more sense to be here. Currently the validation test in minerva-server is more complete (includes Arachne inference step while this does not) and more exactly matches the conditions in the server (running with models in a MMManager). This one is useful for testing as it runs faster.
Shex validation model metadata
and added an example for testing.
Will want to revisit with @kltm on desired structure for interface code.
need to be careful to avoid making tests with redundant graph uris. These get overwritten during load to blazegraph, causing confusion. Added a test for that. Updated to download and use merged go-lego file.
…idation-report Add cardinality to shex validation report
believe this cure issue #333
add search by model id
allow for multiple ids in search
…response adding root types for partial model responses
In particular, started on some graph oriented metrics.
This cures some problems with reading owl ontologies out of RDF via the Rio library. On a small fraction of models, notably those that imported go-lego-reacto.owl , the title for the model would not make it into the OWLOntology annotations. Switching to 4.5.15 fixed this in all cases tested.
the information will just show up in the tab-delimited output file previously containing just the shex and owl result for each gocam.
This way we can compute on gpad if we want to without reading it out as a string. Just used at the moment for getting row count for stats.
fixBrokenObjectPropertiesAndAxioms alleviates problems with object properties being read in as annotation properties. It uses the RO namespace to guess what should be an object property and what should not. With the OWL-API update, this may not be useful anymore. Also added a simple test to see if a gocam has the go-lego import statement.
Also made more things just on be default to reduce parameter explosion.
leaving the gocam instance ontology alone, but replacing the term with its replacement for calculating stats.
This will include the fix from #341 as well as improving the command line access for the gocam model stats - and adding a new activity-node centric report.
|
@vanaukenk @ukemi We're going to go ahead with this and can see if we are getting the missing annotations through on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
root types, better gpad, and more!