Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return 400 when url-based upload is detected #96

Merged
merged 2 commits into from
Apr 27, 2023

Conversation

lukfor
Copy link
Member

@lukfor lukfor commented Apr 13, 2023

This pull request checks before job creation if a file parameter is url-based and returns status 400.

@lukfor lukfor mentioned this pull request Apr 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2023

Codecov Report

Merging #96 (68593a1) into master (d8bad96) will decrease coverage by 0.03%.
The diff coverage is 51.28%.

@@             Coverage Diff              @@
##             master      #96      +/-   ##
============================================
- Coverage     40.30%   40.27%   -0.03%     
- Complexity     1072     1073       +1     
============================================
  Files           183      183              
  Lines          9024     9030       +6     
  Branches       1110     1111       +1     
============================================
  Hits           3637     3637              
- Misses         5106     5109       +3     
- Partials        281      284       +3     
Impacted Files Coverage Δ
...n/java/cloudgene/mapred/api/v2/jobs/SubmitJob.java 69.41% <51.28%> (-2.54%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lukfor lukfor merged commit 6f656f2 into master Apr 27, 2023
@lukfor lukfor deleted the fixes/improve-job-submission branch May 9, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants