Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image component not honoring width when inside Flex container #129

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ggallotti
Copy link
Member

@ggallotti ggallotti commented Aug 13, 2020

@ncardeli:
The problem is that when the Image Component is placed inside a Flexbox container, the Width is not honored, but fills the entire container.

image

I think that the Image component is the only component whose size can be established via Theme with Image Width and Height (and may not fill the entire "row".) (So, it's size is not inherited from the parent Cell )

I also considered setting the Width to the IMG, but we must resize the whole container, not only the IMG inside, because we expect that Borders are applied to the whole container.

I've added a maxWidth attribute for this.

@ncardeli what do you think? Better ideas are welcome. ;)

@ggallotti ggallotti requested a review from ncardeli August 13, 2020 20:21
@ncardeli
Copy link
Contributor

Sounds good to me; just verify that everything works as expected when autoGrow=true and autoGrow=false.
This component changes the way it renders radically when autoGrow is toggled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants