This repository has been archived by the owner on Oct 26, 2021. It is now read-only.
IP-3074 - Documentation Discrepancies #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtModels into IP-2482/v7.3-GMS
* Catalog Variable Set created
kenanM
reviewed
Feb 20, 2019
| ], | ||
| "multiValue": false, | ||
| "type": "CATEGORICAL", | ||
| "description": "tumourType, e.g. Primary, Metastatic, Unknown" | ||
| "description": "tumourType - Nothe there is a break change from last version here" |
kenanM
reviewed
Feb 20, 2019
| @@ -14,9 +14,9 @@ protocol CommonParticipant { | |||
| NON_HODGKINS_B_CELL_LYMPHOMA_LOW_MOD_GRADE, CLASSICAL_HODGKINS, NODULAR_LYMPHOCYTE_PREDOMINANT_HODGKINS, T_CELL_LYMPHOMA} | |||
|
|
|||
| /** | |||
| NOTE: In GMS, this has been deprecated in favour of TumourPresentation and PrimaryOrMetastatic fields | |||
| NOTE: This has been changed completly they previos tumour type has been split in TumourPresentation and PrimaryOrMetastatic | |||
There was a problem hiding this comment.
This has been changed completely the previous tumour type has been split into TumourPresentation and PrimaryOrMetastatic
kenanM
reviewed
Feb 20, 2019
kenanM
approved these changes
Feb 20, 2019
Antonior26
added a commit
that referenced
this pull request
Jun 22, 2019
* Changes for NGIS + Exit Questionnaire for CNV and STRs * test fixed * setting indentation right!! * refactor referrals * change diagnostic details to a list * fix typos + rename UID * add consent * added flags for CNVs and participant flags * bringing back old consent status and renaming the new one to GmsConsentStatus * Updated NGIS model to include ClinicalIndication,and updated Organisation. Updated CommonParticipant to have ClinicalIndication * Clinical Indication test and technology refactored in records * Updated TumourSample from clinical discussion with Clare Craig, Alona Sosinsky, Antonio Rueda Martin. Added diseasePenetrance at referralTestlevel from request by Ellen Thomas for NGIS * Update dependency manager for VERSION_72 * Added preparationMethod LI_HEP * updated HPOTermModifiers and preparationMethod * added technology and test clinical indication to test * fixed bug with Technology being used before declared * removed duplication of clinicalindicationtest field * Updates to reflect DDF->CDI Clinical Review Meeting * Updated NGIS models with tumour record, updated cancer model * all records using date with exception of clinicalSampleDate have been normalised using the Date record * updated Date record to use int instead of string * updated typo in TumourTopography * Updated Tumour Sample and Germline Sample comprehensively from meetings with Cancer and RD clinicians * Updated NgisTumourType due to typo * Updated CommonParticipant due to typo * Updated Ngis ReferralTest to be tumourSample instead of somaticSample * Update Storage Medium to include FFPE * * Changed CVA 1.2 to 1.3 as 1.2 exists already in develop * Changed build version to 7.3 * * corrected build.json after merge * case in date's fields corrected * * Added 7.3 to json and added python modules * Add NGIS Germline and Tumour sample variablesets (#439) * fixed typo * Fixed Tumour.tumourType use NgisTumourType enum * Updated Priority Enum to reflect DDF payload * IP-3074 - Documentation Discrepancies (#443) * catalog referral model after changes * * Fixes describe in IP-3074 * Catalog Variable Set created * * typos * * version changed * IP-3074 - Documentation discrepancies (#449) * catalog referral model after changes * * Fixes describe in IP-3074 * Catalog Variable Set created * * typos * * version changed * * IndividualId changed to ParticipantId * TumourPresentation/PrimaryOrMetastatic moved to Tumour * * Fixes describe in IP-3074 * Catalog Variable Set created * * IndividualId changed to ParticipantId * TumourPresentation/PrimaryOrMetastatic moved to Tumour * removed unneeded spaces * Added GMS (testConsent) to the cancer and rd participant models (#450) * Added GMS (testConsent) to the cancer and rd participant models * Added collection to referral payload, Morphology and Topography use now a property like format. * Requested changes * added version for ontology in morphology and topography (#454) * Add three new models for the new summary.csv files to be delivered by illumina as part of NGIS (#453) * IP-3485 - GMS DDF fixes + Cancer Diagnosis addition (#469) * * Fixes for DDF raredisease * Addition of Cancer Diagnosis * consolidating participant ID and individual ID in Cancer Participant * IP-2482: update docker images to match develop branch which works * sets the right java build version * fix cva versioning * Revert "fix cva versioning" This reverts commit 0491b0f. * some refactoring to CVA models * refactor cva models
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.