Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diluc a4 passive always on #100

Closed
HanSeoulOh opened this issue Dec 12, 2021 · 1 comment
Closed

Diluc a4 passive always on #100

HanSeoulOh opened this issue Dec 12, 2021 · 1 comment

Comments

@HanSeoulOh
Copy link
Member

gcsim/internal/characters/diluc/abil.go

Line 115 in 3f5166b

// add 20% pyro damage

This should only be for a4.. guess it's not too big of a deal though if your diluc is leveled
@srliao
Copy link
Contributor

srliao commented Dec 12, 2021

Sim for now assumes everyone lvls their char to 60/70 at least.

could be something to revisit in future if there's a need for this

@srliao srliao closed this as completed Dec 12, 2021
theqp pushed a commit to theqp/gcsim that referenced this issue Aug 9, 2022
@srliao
Merge pull request genshinsim#100 from soloxcx/patch-1
11a969c 
Update Disclaimer.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@srliao @HanSeoulOh