Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a param for Childe activating E while moving or not (but maybe don't make it 1 frame) #498

Closed
soloxcx opened this issue Apr 27, 2022 · 4 comments

Comments

@soloxcx
Copy link
Contributor

soloxcx commented Apr 27, 2022

Childe's skill, if activated while moving, is 1 frame long. The user should have the option to do this

However, making it 1 frame in the sim will cause issues with stealing vaporizes from his burst in the common sequence burst, skill. This interaction is verifiable in game, but I'd rather not have every Childe user be forced to type a wait in order for the skill to not damage before his burst lands. So maybe make his moving skill long enough that this doesn't happen (5 frames?)

Also I think his "moving" skill should be the default behavior and "nonmoving" should be the param e.g. skill[nonmoving=1]

@k0l11
Copy link
Collaborator

k0l11 commented Apr 27, 2022

related to #209
Idk about artificially extending/delaying his E when walking. If burst followed by skill with no wait results in the E stealing a vape ingame, then it should do the same in the sim. Every Childe user would also wait/dash/... ingame, so the same should be done in the sim config. Can't say much about what the default behaviour should actually be, but I think the user either has to manually input walk, skill or it will be handled via a parameter like you said.

@soloxcx
Copy link
Contributor Author

soloxcx commented Apr 27, 2022

on one hand it makes sense that the behavior should be identical to the game, but my understanding is the timing window is so short that you need exceptionally low ping/reaction time to steal the vape from his burst. it's something that is rarely ever talked about in Childe circles, I feel like it would cause a lot of sudden confusion until it is known "okay, you have to enter a wait cause his moving E is too fast for the frame perfect sim". i'm not against that being deemed a necessary side-effect of in game accuracy though.

@k0l11
Copy link
Collaborator

k0l11 commented Apr 27, 2022

The initial confusion is something that I wouldn't mind if it means being accurate to how it is ingame.
Video with dash instead of walk

@k0l11
Copy link
Collaborator

k0l11 commented Aug 12, 2022

check if this is still an issue once #667 is merged

@k0l11 k0l11 closed this as completed Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants