Tartaglia frame adjustment #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tartaglia needs a custom dash to account for dash skill activation.
Tartaglia skill should use no ICD tag.
If Tartaglia's charge hits a weakspot, it will trigger aimshot-like hitlag, where Targ himself won't lag but the target will. We consider this to be deployable hitlag.
The cooldown for deactivating the skill CD should be 0 or 14 depending on the previous action.
Depending on Tartaglia's previous action, the delay of activating the skill CD changes.
We don't have to check if the active player is Tartaglia.
This describes the variable better, to show where in the multi hit we are so that we can count frames properly.
We don't need to initialize the struct each time we loop through an attack.
This should use CurrentState() and no need to check for actor.
k0l11
reviewed
Aug 9, 2022
k0l11
reviewed
Aug 9, 2022
k0l11
reviewed
Aug 9, 2022
Childe's melee CA is still hitlagless, it's just the aim shot that has deployable hitlag.
skippi
force-pushed
the
tartaglia-adjust
branch
from
f04af21 to
6d3637f
Compare
Tartaglia needs at least 4f walking before walk -> skill is possible. I think this is the best compromise to keep walking at 1f.
We need to respect whatever value the user puts in for animation length.
Status use hitlag, so I made the decision to use these to represent the riptide timers.
Most bow attacks do not have ICD.
shizukayuki
reviewed
Aug 14, 2022
Since this is an illegal move, we need to add a sizeable amount of lag to discourage its use.
We can just sum the frames ahead of time to reduce the amount of code needed.
Because the attack info was instantiated outside of the loop, the delayed char task would use the attack info at the time of it being called. This would usually be the last multi-hit.
We can sum the hitmarks and simplify the following code.
|
the max possible melee duration does get extended by hitlag |
Because tartaglia's frames depend on the previous action, the correct `CanQueueAfter` depends on the selected frame cancels. We need to manually find the minimum frame cancel.
Note that this does NOT change the cooldown calculation for swap/disable action. This is only for making sure Tartaglia can stay on his melee duration for max duration with hitlag included.
k0l11
reviewed
Aug 14, 2022
When tartaglia hits the max skill duration is dependent on hitlag.
skippi
force-pushed
the
tartaglia-adjust
branch
from
e54c9e3 to
53c4095
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: Tagging #209.