Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kinich #2263

Merged
merged 18 commits into from
Jan 2, 2025
Merged

Add Kinich #2263

merged 18 commits into from
Jan 2, 2025

Conversation

ange1o5
Copy link
Contributor

@ange1o5 ange1o5 commented Nov 1, 2024

  • New character package
  • Config in character package
  • Run pipeline with added config (generates character curve, talent stats, .generated.json files)
  • Character key
  • Shortcuts for character key
  • Update mode_gcsim.js with shortcuts for syntax highlighting
  • Add Character package to imports
  • Normal Attack
  • Charge Attack / Aimed Shot
  • Skill
  • Burst
  • A1
  • A4
  • C1
  • C2
  • C3
  • C4
  • C5
  • C6
  • Other necessary talents (custom dash/jump, low/high plunge, ...)
  • Hitlag
  • ICD
  • StrikeType
  • PoiseDMG (blunt attacks only for now)
  • Hitboxes
  • Attack durability
  • Particles
  • Frames
  • Update documentation
  • Xingqiu/Yelan N0 (optional)
  • Xianyun Plunge (optional)

@imring imring added area: internal Related to artifacts/weapons/characters kind: game alignment Missing mechanic from the game labels Nov 1, 2024
internal/characters/kinich/asc.go Show resolved Hide resolved
internal/characters/kinich/burst.go Outdated Show resolved Hide resolved
internal/characters/kinich/burst.go Show resolved Hide resolved
internal/characters/kinich/burst.go Outdated Show resolved Hide resolved
internal/characters/kinich/cons.go Show resolved Hide resolved
internal/characters/kinich/skill.go Outdated Show resolved Hide resolved
internal/characters/kinich/skill.go Outdated Show resolved Hide resolved
@ange1o5
Copy link
Contributor Author

ange1o5 commented Nov 17, 2024

Other issues:

  • C6 DPS is down by 100k (multitarget)
  • C1 DPS is down by 4k (single target)
kinich char lvl=90/90 cons=1 talent=9,9,9 ;
kinich add weapon="fotmk" refine=1 lvl=90/90;
kinich add set="obsidiancodex" count=4;
kinich add stats hp=4780 atk=311 atk%=0.466 dendro%=0.466 cr=0.311 ; #main
kinich add stats def=39.36 def%=0.124 hp=507.88 hp%=0.0992 atk=33.08 atk%=0.1984 er=0.1102 em=39.64 cr=0.3972  cd=0.662 ;        

thoma char lvl=90/90 cons=0 talent=9,9,9; 
thoma add weapon="favoniuslance" refine=3 lvl=90/90;
thoma add set="deepwood" count=4;
thoma add stats hp=4780 atk=311 er=0.518 hp%=0.466 cr=0.311 ; #main
thoma add stats def=39.36 def%=0.124 hp=507.88 hp%=0.0992 atk=33.08 atk%=0.1984 er=0.6402 em=39.64 cr=0.331 cd=0.124;

emilie char lvl=90/90 cons=0 talent=9,9,9;
emilie add weapon="deathmatch" refine=1 lvl=90/90;
emilie add set="ur" count=4;
emilie add stats hp=4780 atk=311 atk%=0.466 dendro%=0.466 cd=0.622 ; #main
emilie add stats def=39.36 def%=0.124 hp=507.88 hp%=0.0992 atk=33.08 atk%=0.1984 er=0.1102 em=39.64 cr=0.3972  cd=0.662 ;        

bennett char lvl=90/90 cons=6 talent=9,9,9;
bennett add weapon="alleyflash" refine=1 lvl=90/90;
bennett add set="no" count=4;
bennett add stats hp=4780 atk=311 er=0.518 pyro%=0.466 cr=0.311 ; #main
bennett add stats def=39.36 def%=0.124 hp=507.88 hp%=0.0992 atk=33.08 atk%=0.0992 er=0.551 em=39.64 cr=0.1986 cd=0.662;

options swap_delay=12 iteration=500;
target lvl=100 resist=.1 hp=10000000 radius=1 pos=-1,2.5;
#target lvl=100 resist=.1 hp=10000000 radius=1 pos=1,2.5;
energy every interval=480,720 amount=1;

fn kinich_combo() {
  kinich skill;
  kinich attack[direction=.kinich.blind_spot];
  if .kinich.burst.ready {
    kinich burst;
  }
  while .kinich.nightsoul.state {
    if .kinich.nightsoul.points == 20 {
      kinich skill[hold=1];
      continue;
    }

    // does not exist at the moment
    let blind_spot = .kinich.blind_spot;
    if blind_spot == 0 {
      if .kinich.nightsoul.points < 20 {
        wait(30);
      }
      continue;
    } else {
      kinich attack[direction=blind_spot];
      continue;
    }
  }
}

active emilie;
for let i=0; i<4; i=i+1 {
  if .emilie.burst.ready {
    emilie burst;
  } else {
    emilie skill;
  }
  thoma skill, burst, attack;
  bennett skill, burst, attack;
  kinich_combo();
}

@srliao srliao merged commit 5f47cb8 into genshinsim:main Jan 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: internal Related to artifacts/weapons/characters kind: game alignment Missing mechanic from the game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants