fix artifacts & some bugs #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- char queue now loops over all actions in queue - exile ticks are affected by hitlag, exile status should not be on the holder but on the party member
- hod status should also be affected by hitlag otherwise the mod and status don't line up - factor out buff duration into own variable
- without this check weird stuff happens (actions in the future extend mods in the past)
- 6s timer still broken
- forgot to check if a task added another task
- remove unused status
- instructor should give em to the holder as well
- duration is now affected by hitlag properly
- change from expiry -1 - refreshes buff now instead of ignoring, because that matches ingame - special case ganyu 4 noblesse interaction (with a TODO)
- icd should be affected by hitlag
- icd should be affected by hitlag
- icd should be affected by hitlag
- icd should be affected by hitlag - remove unused status
- icd should be affected by hitlag
- icd should be affected by hitlag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also fixes:
missing:
rewrites:
todo:
check noblesse