Ningguang frame adjustment #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful for intentionally destroying the construct.
Also added handler for choosing the next attack type according to RNG.
We still have some work to do with checking her idle -> CA frames, or even her repeat CA frames. But this will work for 90% of her configs.
Also refactored out usage of Tags where possible.
It still won't work since the parser is incorrect, but now the conditionals are in correct format.
Adding these for people who want to check if parts of the burst miss.
Particle ICD shorten name and fix conditional matching.
Ningguang's burst shards snapshot as soon as the burst activates. The shards that come from the screen have a separate snapshot mechanic.
Ningguang only uses two of her charge attacks if she follows her NA with a CA. It follows as below: - Left/Twirl NA -> Left CA - Right NA -> Right CA The twirl CA is only used when CA is casted standalone. CAs outside of the NA pattern are chosen by random.
From what Koli and I perceive, Ningguang has a state machine-like pattern for her idle CAs. These are based on the previous normal attack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frame adjustment for #209 .