Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some bow icd tags #728

Merged
merged 1 commit into from
Aug 15, 2022
Merged

fix some bow icd tags #728

merged 1 commit into from
Aug 15, 2022

Conversation

k0l11
Copy link
Collaborator

@k0l11 k0l11 commented Aug 12, 2022

fixes #548

  • aloy na without e buff and na with e buff should have different icd tags
  • venti ca icd was wrong
  • yoimiya na without e buff and na with e buff should have different icd tags

- aloy na without e buff and na with e buff should have different icd tags
- venti ca icd was wrong
- yoimiya na without e buff and naa with e buff should have different icd tags
@srliao srliao merged commit b39feaf into genshinsim:main Aug 15, 2022
@k0l11 k0l11 deleted the fix-bow-na-icd branch August 18, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yoimiya normals should not share icd tag pre and post buff?
2 participants