Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anemo/geo/electro traveler frames updates and bug fixes #734

Merged
merged 10 commits into from
Aug 17, 2022

Conversation

k0l11
Copy link
Collaborator

@k0l11 k0l11 commented Aug 13, 2022

resolves #63 until new traveler elements are added

core:

  • adds a missing construct creation log to the one construct function that only gets used by travelergeo

common (only affects anemo/geo/electro):

  • implements charge with scaling depending on male/female
  • adds male (travelerXXXmale) and female version (travelerXXX, travelerXXXfemale) of travelerXXX
  • replaces keys.TravelerXXX with keys.TravelerXXXMale and keys.TravelerXXXFemale

anemo:

  • switches to using particledelay flag for hold e
  • adjusts noblesse special case because of keys change
  • fixes a1 abil name
  • adds missing hitlag (attack) and hitlag extension (c6)

geo:

  • implements short hold e
  • fixes q dmg start
  • adjusts default number of q shockwave hits (2 -> 4)
  • rewrites c1 buff, because current implementation is wrong (part of check implementation of buffs that depend on deployables #654)
  • fixes c4 not having a limit
  • adjusts q default param value for construct_limit (barrier count, 1 -> 2)
  • adds missing hitlag (attack, e, c2) and hitlag extension (c1)

electro:

  • adds missing hitlag (attack) and hitlag extension (c2)

@k0l11 k0l11 marked this pull request as draft August 14, 2022 15:47
@k0l11 k0l11 marked this pull request as ready for review August 14, 2022 18:59
@k0l11 k0l11 changed the title all traveler frames updates anemo/geo/electro traveler frames updates Aug 17, 2022
@srliao srliao changed the title anemo/geo/electro traveler frames updates anemo/geo/electro traveler frames updates and bug fixes Aug 17, 2022
@srliao srliao merged commit 66feccb into genshinsim:main Aug 17, 2022
@k0l11 k0l11 deleted the traveler-frames branch August 18, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lumine/traveler should be split into separate characters
2 participants