port --secret and --ssh support #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Jan 14, 2021
| @@ -5,7 +5,7 @@ PKG := github.com/genuinetools/$(NAME) | |||
| CGO_ENABLED := 1 | |||
|
|
|||
| # Set any default go build tags | |||
| BUILDTAGS ?= seccomp osusergo | |||
| BUILDTAGS ?= seccomp osusergo dfrunmount dfsecrets dfssh | |||
There was a problem hiding this comment.
These tags should not be needed if you vendor the latest version of BuildKit
There was a problem hiding this comment.
After trying a bit, vendoring the latest (8.1.0) version of BuildKit requires much more effort as it impacts refactoring "pull" and "push" commands due to changes on sessions (e.g., moby/buildkit#1551).
Wouldn't it be better if we open a dedicated issue/PR ?
AkihiroSuda
reviewed
Jan 14, 2021
AkihiroSuda
approved these changes
Feb 12, 2021
|
Would it be possible to support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #198
The current implementation of
img builddoes not support--secretand--ssharguments nor acceptRUN --mount=...instruction.These features are now in GA since docker 20.10 and would be a great addition to
imgThis work is largely inspired from:
Few comments about this work:
moby/buildkitmust be built with tagsdfrunmount dfsecrets dfsshfor--secretand--sshsupportTestBuildSsh. I'm not sure if this was the best way to make a unit test for--sshReferences: