Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

limit 1 #1005

Merged
merged 3 commits into from
Jan 8, 2025
Merged

limit 1 #1005

merged 3 commits into from
Jan 8, 2025

Conversation

ChristianBeilschmidt
Copy link
Member

  • I added an entry to CHANGELOG.md if knowledge of this change could be valuable to users.

Here is a brief summary of what I did:

@coveralls
Copy link
Collaborator

coveralls commented Dec 30, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12557474624

Details

  • 41 of 41 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 90.574%
Files with Coverage Reduction New Missed Lines %
services/src/datasets/external/aruna/mock_grpc_server.rs 1 82.93%
Totals Coverage Status
Change from base Build 12469296660: 0.01%
Covered Lines: 133965
Relevant Lines: 147907
💛 - Coveralls

@michaelmattig michaelmattig added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit ef526ad Jan 8, 2025
6 checks passed
@michaelmattig michaelmattig deleted the limit-1 branch January 8, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelmattig michaelmattig michaelmattig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristianBeilschmidt @coveralls @michaelmattig