Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate-pro-api #1006

Merged
merged 19 commits into from
Jan 14, 2025
Merged

Migrate-pro-api #1006

merged 19 commits into from
Jan 14, 2025

Conversation

ChristianBeilschmidt
Copy link
Member

  • I added an entry to CHANGELOG.md if knowledge of this change could be valuable to users.

Here is a brief summary of what I did:

@coveralls
Copy link
Collaborator

coveralls commented Jan 6, 2025

Pull Request Test Coverage Report for Build 12767279175

Details

  • 1106 of 1152 (96.01%) changed or added relevant lines in 24 files are covered.
  • 247 unchanged lines in 12 files lost coverage.
  • Overall coverage increased (+0.06%) to 90.64%

Changes Missing Coverage Covered Lines Changed/Added Lines %
services/src/util/openapi_examples.rs 20 21 95.24%
services/src/server.rs 0 4 0.0%
services/src/api/handlers/datasets.rs 378 383 98.69%
services/src/util/tests.rs 116 125 92.8%
services/src/api/cli/add_from_directory.rs 0 27 0.0%
Files with Coverage Reduction New Missed Lines %
services/src/api/cli/add_from_directory.rs 1 0.0%
services/src/pro/contexts/postgres.rs 1 97.21%
services/src/api/model/datatypes.rs 3 51.86%
services/src/contexts/mod.rs 5 65.57%
services/src/api/model/responses/datasets/errors.rs 11 0.0%
services/src/util/tests.rs 11 94.85%
services/src/tasks/in_memory.rs 15 86.6%
services/src/contexts/session.rs 17 64.38%
services/src/projects/postgres_projectdb.rs 27 94.01%
services/src/contexts/postgres.rs 39 98.0%
Totals Coverage Status
Change from base Build 12710565624: 0.06%
Covered Lines: 133501
Relevant Lines: 147287

💛 - Coveralls

@ChristianBeilschmidt ChristianBeilschmidt marked this pull request as ready for review January 10, 2025 10:35
@michaelmattig michaelmattig added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit de81b44 Jan 14, 2025
6 checks passed
@michaelmattig michaelmattig deleted the migrate-pro-api branch January 14, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants