Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ml permissions #1007

Merged
merged 16 commits into from
Jan 31, 2025
Merged

Add ml permissions #1007

merged 16 commits into from
Jan 31, 2025

Conversation

jdroenner
Copy link
Member

  • I added an entry to CHANGELOG.md if knowledge of this change could be valuable to users.

Here is a brief summary of what I did:

@coveralls
Copy link
Collaborator

coveralls commented Jan 13, 2025

Pull Request Test Coverage Report for Build 13074893880

Details

  • 401 of 440 (91.14%) changed or added relevant lines in 9 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 90.074%

Changes Missing Coverage Covered Lines Changed/Added Lines %
services/src/machine_learning/mod.rs 0 1 0.0%
services/src/api/handlers/permissions.rs 274 280 97.86%
services/src/error.rs 0 6 0.0%
services/src/datasets/name.rs 46 53 86.79%
datatypes/src/machine_learning.rs 19 38 50.0%
Files with Coverage Reduction New Missed Lines %
services/src/permissions/mod.rs 1 75.44%
Totals Coverage Status
Change from base Build 13055768563: 0.05%
Covered Lines: 125968
Relevant Lines: 139849

💛 - Coveralls

@ChristianBeilschmidt
Copy link
Member

Es wurde ein Feature hinzugefügt, aber nicht getestet. Deshalb auch die geringe Coverage.
Sollte man das Feature nicht testen?

@michaelmattig michaelmattig added this pull request to the merge queue Jan 31, 2025
Merged via the queue into main with commit 092b055 Jan 31, 2025
6 checks passed
@michaelmattig michaelmattig deleted the add_ml_permissions branch January 31, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants