PB 1358: Allow printing measures again #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 01m 48s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
1
|
Skipped
|
0
|
Passing
|
48
|
| View all changes introduced in this branch ↗︎ | |
ltkum
force-pushed
the
fix-PB-1358-fix-printing-for-measures
branch
from
3ff16fc to
4fa426e
Compare
Issue : Measures could not be printed anymore Cause : With the implementation, we had set the graphicYoffset to NaN instead of 0 when there is no offset, meaning the print service could not interpret it Fix : We ensure the graphicYoffset is set to 0 if non existent.
ltkum
force-pushed
the
fix-PB-1358-fix-printing-for-measures
branch
from
4fa426e to
f9bc53b
Compare
pakb
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : Measures could not be printed anymore
Cause : With the implementation, we had set the graphicYoffset to NaN instead of 0 when there is no offset, meaning the print service could not interpret it
Fix : We ensure the graphicYoffset is set to 0 if non existent.
Test link