Use https transport in Yandex provider

[nitso]

No description provided.

[Baachi]

You have to change the exception message in the unit tests.

[willdurand]

Also, I would prefer to keep the http version. Some other providers have a $useSsl option.

[toin0u]

I also think the $useSsl option is the best approach https://github.com/geocoder-php/Geocoder/blob/master/src%2FGeocoder%2FProvider%2FGoogleMaps.php#L80 :)

[toin0u]

Oh Yandex will deprecate http #431.. So this PR makes sense :) But like @Baachi said, tests should be fixed :)

• https://github.com/geocoder-php/Geocoder/blob/master/tests%2FGeocoder%2FTests%2FProvider%2FYandexTest.php#L41
• https://github.com/geocoder-php/Geocoder/blob/master/tests%2FGeocoder%2FTests%2FProvider%2FYandexTest.php#L51
• https://github.com/geocoder-php/Geocoder/blob/master/tests%2FGeocoder%2FTests%2FProvider%2FYandexTest.php#L61
• https://github.com/geocoder-php/Geocoder/blob/master/tests%2FGeocoder%2FTests%2FProvider%2FYandexTest.php#L71
• https://github.com/geocoder-php/Geocoder/blob/master/tests%2FGeocoder%2FTests%2FProvider%2FYandexTest.php#L81
• https://github.com/geocoder-php/Geocoder/blob/master/tests%2FGeocoder%2FTests%2FProvider%2FYandexTest.php#L249
• https://github.com/geocoder-php/Geocoder/blob/master/tests%2FGeocoder%2FTests%2FProvider%2FYandexTest.php#L259
• https://github.com/geocoder-php/Geocoder/blob/master/tests%2FGeocoder%2FTests%2FProvider%2FYandexTest.php#L269

[nitso]

It is a good idea to implement $useSsl switch. Should it be true or false by default?

[toin0u]

I'm not sure because Yandex will use https only soon..

[Baachi]

I would rather throw an exception if the openssl extension isn't installed, because Yandex didn't support http longer.

[willdurand]

Well if http is deprecated, then no need to introduce the useSsl option. However, it implies a sort of soft BC break... I am not sure about how to deal with that..

[nitso]

I've fixed tests that mentioned http. But there is still one failing. Can't really say why.
There is a difference in Yandex response for http and https queries in tests:

I'll fix it either :)

[willdurand]

sounds good to me. could you please squash your commits?

[nitso]

Done.

I've added cached responses as well.

[willdurand]

thank you very much!