Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to Neptune theme #202

Merged
merged 1 commit into from
Nov 4, 2013
Merged

switch to Neptune theme #202

merged 1 commit into from
Nov 4, 2013

Conversation

bartvde
Copy link
Member

@bartvde bartvde commented Oct 28, 2013

I think a lot of people are tired of seeing the default Ext blue theme, can we switch to the Neptune theme? I'm happy to work on a PR if we have consensus.

http://docs.sencha.com/extjs/4.2.2/extjs-build/examples/build/KitchenSink/ext-theme-neptune/#basic-panels

@juliensam
Copy link
Contributor

I agree that people are tired of the blue theme so I'm +1 for this. We should also point to the ExtJS custom theme documentation. ExtJS4 was easier to theme if I recall correctly: http://docs.sencha.com/extjs/4.2.1/#!/guide/theming

@marcjansen
Copy link
Member

Can we possibly even have a the switcher on the examples? A pull request would be much appreciated.

@marcjansen
Copy link
Member

http://docs.sencha.com/extjs/4.2.1/extjs-build/examples/shared/include-ext.js might be nice to control the style depending on the URL parameter or a cookie value.

The method swapStyleSheet will leave you with too much padding between elements when switching from neptune to e.g. classic.

@bartvde
Copy link
Member Author

bartvde commented Oct 28, 2013

adding the theme switcher makes sense to me, will work on a PR

@chrismayer
Copy link
Contributor

I am sure people are fed up with the blue default CSS. But if everyone likes the Neptune one? I am not sure so I would also love to see the switcher within the examples.
@marcjansen is the script you mentioned the one which is used in the official examples offering the combo, like here: http://docs.sencha.com/extjs/4.2.1/extjs-build/examples/feed-viewer/feed-viewer.html

I also agree with @juliensam to point to the possibilty of making your custom theme. Should we offer a tutorial upon the ExtJS theming tutorial? I am not sure cause the Ext one is very detailed.

@bartvde
Copy link
Member Author

bartvde commented Oct 28, 2013

@chrismayer so are you saying you're +1 on including the Ext theme combo box in our examples?

@chrismayer
Copy link
Contributor

Yes, @bartvde

+1 from my side

@bartvde
Copy link
Member Author

bartvde commented Oct 28, 2013

ready for review

@marcjansen
Copy link
Member

Nice work, @bartvde. Please merge.

The popup example isn't looking really good in the neptune theme, but I think this is a different story.

bartvde pushed a commit that referenced this pull request Nov 4, 2013
@bartvde bartvde merged commit f39dbf0 into geoext:master Nov 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants