Add and use a base class for mappanel sliders. #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * Once we are rendered and we know that we are a child of a | ||
| * mappanel, we need to make some adjustments to our DOMs | ||
| * box dimensions. | ||
| * mappanel, we bind our event hanlders to the map. |
|
LGTM @marcjansen put in two minor comments |
This reduces the amount of copied code and reuses the methods from the base class.
marcjansen
added a commit
that referenced
this pull request
Oct 29, 2013
Add and use a base class for mappanel sliders. (r=@bartvde)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the amount of copied code and reuses the methods from the base class.
All tests pass in IE8, Chrome 30 and Firefox 24, The examples work as expected in these browsers.
Please review.
PS: The Zoom slider example still shows some glitches when the slider outside of the mappanel is being used in a quick manor. AFAICT this is not related to the changes in this PR, as it can e.g. be reproduced in the online example. I opened a separate issue for this behaviour: #205.