automated screenshots with phantomjs and image magick

[hutzelknecht]

the screenshots can be taken by the following command

~$ . screenshots.sh http://geoext.github.io/geoext2/examples/

dependencies are phantomjs and imagemagick. The Script has been tested on an Ubuntu 13.04 machine.

[marcjansen]

Great! Will test this now.

Do you see any chance of making jsuck.json on master look exactly as on gh-pages?

[marcjansen]

For future pull requests (which I hope you'll be submitting plenty of), please work an explicit feature-branch.

[marcjansen]

Better: exampleUrl=$1

No spaces around =

[hutzelknecht]

OK

[marcjansen]

This is very nice, thanks a ton @hutzelknecht.

Some remarks.

• I added a couple of comments to screenshot.sh and want to add some more here:

  • Could you please add #!/usr/bin/env bash as the first line of the script?
  • Could you make this script callable from everywhere by using absolute paths to example.js. The following lines may help:

  BASEDIR=$(dirname $0)
  WORKDIR=$(pwd -P)
  cd $BASEDIR
  BASEDIR=$(pwd -P)
  cd $WORKDIR

  • can you add a simple check whether phantomjs is available, sth. like:

  function chkcmd {
      which $1 >/dev/null
      if [ $? -ne 0 ];then
          echo "Program '$1' not found."
          exit 1
      fi
  }

  you can then just call this like chkcmd "phantomjs"

• The screenshot.js-file should not use tabs and needs some love with regard to documentation, formatting, indentation and also should use curly-braces even for on-line branches.

• I'd also put the two utility files into their own dedicated tools-folder on the root of the repo.

• Please add a note in the main README.md how to regenerate the images.

• Please try to make jsduck.json look exactly like it's counterpart on the gh-pages-branch

These are a lot of comments, I know. If you are able to address some of these I'd be very happy. If not, We can fix this in a follow-up pull request. Just tell me whether you agree and whether you have time for this.

To sum it up: Awesome work, @hutzelknecht! This will (in one way or the other) be merged once I have your feedback.

[hutzelknecht]

Will fix the remaining remarks tonight.

[hutzelknecht]

with a0b7492 everything should be fixed. @marcjansen could you please see if it still works on your machine?

[marcjansen]

I will test this. But this has to wait until after Easter. I'll mostly be offline until next Tuesday.

[marcjansen]

This won't work. I'll create a follow up PR to adress this.

[marcjansen]

I added only one comment, which I'll address in a follow-up PR.

Thanks!