Make GeoExt.Overview inherit from Ext.Component #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bentrm you are right, extending from Ext.Component would be more straight forward due to the arguments you wrote in your comment. Seems that we all missed this or does someone else arguments against this especially @marcjansen since he has been strongly involved in #288 ? |
|
I agree. If @marcjansen is with us I will change the alias to |
|
👍 for We're in between releases, so no harm done IMO |
|
This should be good to go now. |
|
Thanks again, @bentrm. |
marcjansen
added a commit
that referenced
this pull request
Nov 5, 2014
Make GeoExt.Overview inherit from Ext.Component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just realized after the fact that letting the overview component inherit from Ext.container.Container would invite to add child items to it which will not work (and probablly shouldn't anyway). Also, I think it's cleaner to go for Ext.Component as it will also reduce the footprint of the overview. Sorry, for introducing this change after the merge of #288.