Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for integration tests #8625

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

davidblasby
Copy link
Contributor

@davidblasby davidblasby commented Jan 28, 2025

This does the following:

  1. Set the integration test's elastic so it will NOT give low disk watermark error messages and refuse to start if your disk is >90% full.

    • for core/
    • for services/
  2. Set services so that it runs on a single JVM. This was because elastic is shared between all the different test cases - some tests were modifying the data at the same time (cf Formatter / Use portal filter #8263), causing inconsistencies as to the uuid of metadata record id=100.

  • this could cause some slow downs during the integration tests for services/. However, the slowdown was very small on my local computer. This is something to keep an eye on.
  1. One of the integration tests KeywordsApiTest#testImportOntologyToSkos uploaded a file - this would be written (by the ThesaurusManager) to the file system (WEB-INF). On the next run, the test would give an error saying the thesaurus already exisits
  • I've added some cleanup code to this test case.

This is problematic on development machines with low disk available (>90% full), and quite difficult to remedy.

I suspect that this hasn't been noticed because the build server;

  1. has enough disk space (<90% full)
  2. only runs the integration tests once (the added thesaurus isn't visible on the first run because WEB-INF is clean)
  3. Formatter / Use portal filter #8263 hasn't been merged yet.

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@davidblasby
Copy link
Contributor Author

@davidblasby davidblasby changed the title elastic testing instance config - 'low disk watermark' Changes for integration tests Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants