Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does the following:
Set the integration test's elastic so it will NOT give
low disk watermark
error messages and refuse to start if your disk is >90% full.core/
services/
Set
services
so that it runs on a single JVM. This was because elastic is shared between all the different test cases - some tests were modifying the data at the same time (cf Formatter / Use portal filter #8263), causing inconsistencies as to the uuid of metadata recordid=100
.services/
. However, the slowdown was very small on my local computer. This is something to keep an eye on.KeywordsApiTest#testImportOntologyToSkos
uploaded a file - this would be written (by the ThesaurusManager) to the file system (WEB-INF). On the next run, the test would give an error saying the thesaurus already exisitsThis is problematic on development machines with low disk available (>90% full), and quite difficult to remedy.
I suspect that this hasn't been noticed because the build server;
Checklist
main
branch, backports managed with labelREADME.md
filespom.xml
dependency management. Update build documentation with intended library use and library tutorials or documentation