Support http links in the Géo-IDE transformation #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simple change makes it so that links specified using the `http://` protocol are automatically upgraded to `https://`, for which there is already a redirection on the Géo-IDE side. Handling this upgrade during harvesting avoids getting a 301 redirection later on when downloading the data for the datahub, as the 301 redirection will bypass the proxy and make a CORS error show up.
|
LGTM, thanks Olivia ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple change to Géo-IDE records makes it so that links using the
http://protocol are automatically upgraded tohttps://, for which there is already a redirection on the Géo-IDE side.Handling this upgrade during harvesting avoids getting a 301 redirection later on when downloading the data for the datahub, as the 301 redirection will bypass the proxy and make a CORS error show up.
To see a record which advertises WxS services in HTTP: http://catalogue.geo-ide.developpement-durable.gouv.fr/catalogue/srv/api/records/fr-120066022-jdd-0b5c2019-2bc1-4188-8a7c-bcb8630c1073/formatters/xml
Using the modified transformation part of this PR, this gives: https://dev.geo2france.fr/geonetwork/srv/api/records/fr-120066022-jdd-0b5c2019-2bc1-4188-8a7c-bcb8630c1073/formatters/xml?approved=true
