Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clone cfg to make it importable from other files; remove pl dependency on load #1

Open
wants to merge 3 commits into
base: camera-ready
Choose a base branch
from

Conversation

alexstoken
Copy link

Hi Georg,

I'm trying to integrate this work into https://github.com/gmberton/image-matching-models (IMM) and found a few hiccups.

  1. importing the cfg doesnt take up the changes from within the file unless the cfg is cloned at the top
  2. pytorch lightning is required to load due to its one function call inside utils/misc.py and that the model checkpoints are saved as lightning checkpoints. Fix for the former is in this PR, for the latter I saved out only the state dict (removing the optimizer, etc from the .ckpt file you share) and saved that out at https://drive.google.com/drive/folders/1VDYMw-vZ9aE_0cNOPNEz08DeLfQPapKO

If these look ok to you then we could add this to IMM. Thanks and thanks for all your great work on this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant