Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

function_metadata_value should support boolean and float #1288

Closed
1 of 2 tasks
xzdandy opened this issue Oct 14, 2023 · 0 comments · Fixed by #1296
Closed
1 of 2 tasks

function_metadata_value should support boolean and float #1288

xzdandy opened this issue Oct 14, 2023 · 0 comments · Fixed by #1296
Assignees
@gaurav274
Labels
Bug 🐞 EVA is not working as expected Feature Request ✨ New feature or request
Milestone
v0.3.8

Comments

@xzdandy
Copy link
Collaborator

xzdandy commented Oct 14, 2023

Search before asking

  • I have searched the EvaDB issues and found no similar feature requests.

Description

https://github.com/georgia-tech-db/evadb/blob/staging/evadb/parser/evadb.lark#L54

Currently we only support

function_metadata_value: string_literal | decimal_literal

Use case

No response

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
@xzdandy xzdandy added the Feature Request ✨ New feature or request label Oct 14, 2023
@gaurav274 gaurav274 self-assigned this Oct 17, 2023
@gaurav274 gaurav274 added this to the v0.3.8 milestone Oct 17, 2023
@gaurav274 gaurav274 mentioned this issue Oct 17, 2023
Merged
xzdandy pushed a commit that referenced this issue Oct 17, 2023
@gaurav274
feat: function_metadata supports boolean and float (#1296)
036e203 
Fixes #1288
@xzdandy xzdandy added the Bug 🐞 EVA is not working as expected label Oct 17, 2023
a0x8o pushed a commit to alexxx-db/eva that referenced this issue Oct 30, 2023
@gaurav274 @a0x8o
feat: function_metadata supports boolean and float (georgia-tech-db#1296
e0596f6 
)

Fixes georgia-tech-db#1288
a0x8o pushed a commit to alexxx-db/eva that referenced this issue Nov 22, 2023
@gaurav274 @a0x8o
feat: function_metadata supports boolean and float (georgia-tech-db#1296
2e202f3 
)

Fixes georgia-tech-db#1288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gaurav274 gaurav274

Labels
Bug 🐞 EVA is not working as expected Feature Request ✨ New feature or request
Projects
EVA Public Roadmap ⚡🚀
Status: Done
Milestone
v0.3.8
Development

Successfully merging a pull request may close this issue.

feat: function_metadata supports boolean and float georgia-tech-db/evadb
2 participants
@xzdandy @gaurav274