Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code inconsistency #456

Closed
gaurav274 opened this issue Nov 1, 2022 · 2 comments · Fixed by #509
Closed

Code inconsistency #456

gaurav274 opened this issue Nov 1, 2022 · 2 comments · Fixed by #509
Assignees

Comments

@gaurav274
Copy link
Member

@xzdandy What happens if the table already exists? This raised an issue that I did not notice before. I was using if_not_exists in the load executor. In mat executor, we can use handle_if_not_exists because the catalog entry is created in the mat executor. But this is not the case for the load operator, the catalog entry is created before the load executor. I think we shall choose one way for both of them. And update the mat, load design, and this creates (e.g., doc what happens the table exists, remove **kwargs, add a call to check whether a table exists or can we use read to do it?)

@xzdandy
Copy link
Collaborator

xzdandy commented Nov 1, 2022

Thanks Gaurav. Noticed in the EXPLAIN PR, #444 (comment) The binder is called. If that's the case, the catalog entry can not be created in the binder. All "permanent" changes need to be done in the executor.

@xzdandy xzdandy self-assigned this Nov 2, 2022
@xzdandy
Copy link
Collaborator

xzdandy commented Nov 2, 2022

After discussing with Gaurav, we will move the load binder logic into the executor.

@xzdandy xzdandy linked a pull request Nov 30, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants