Move load and upload out of binder. #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
gaurav274
approved these changes
Dec 1, 2022
jiashenC
reviewed
Dec 1, 2022
| ColumnDefinition( | ||
| "name", ColumnType.TEXT, None, [], ColConstraintInfo(unique=True) | ||
| ), | ||
| ColumnDefinition("id", ColumnType.INTEGER, None, []), |
There was a problem hiding this comment.
Do we still want to use a explicit id column or change to _row_id column?
There was a problem hiding this comment.
@jiashenC The function is moved out from the binder for clarification (since it is not used in binder anymore). No modifications are made. Regarding the id vs _row_id, I do not have preference, either works.
There was a problem hiding this comment.
Sure, just get your opinion if we can get rid of this redundant column. Others LGTM.
There was a problem hiding this comment.
Just come to my mind, under the current implementation. id and _row_id are different when a dataset has more than 1 video. id restarts from 0/1 for every video. _row_id probably should not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the explain command, the catalog operations required by load and upload can not be completed in the binder. Move them to executor instead.