Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset layer iteration and FieldValue types #126

Merged
merged 1 commit into from
Dec 15, 2020

Conversation

manimaul
Copy link
Contributor

@manimaul manimaul commented Dec 2, 2020

I can chop this PR up into 2 separate PRs if you'd like as it addresses 2 issues #124 and #125. Also, I've included a test fixture that is a NOAA S57 vector marine chart. This too can be changed to something else if there is a preference. The fixture just happens to be the type of dataset I need these additional features in the PR for.

LMK if you'd like to see any changes. I'm flexible - thank you

@jdroenner
Copy link
Member

thank you for this enhancement. i merged some older PRs which created merge conflicts. could you solve them?
I think the test data is very large. Could you generate a smaller test dataset?

Verified

This commit was signed with the committer’s verified signature.
manimaul William Kamp
add iterator for fields in feature
add accessors for additional ogr field types.

FieldValueIterator skip unknown types but does not terminate until field count reached
@manimaul
Copy link
Contributor Author

manimaul commented Dec 6, 2020

thank you for this enhancement. i merged some older PRs which created merge conflicts. could you solve them?
I think the test data is very large. Could you generate a smaller test dataset?

No problem. I've generated a 3 layer sqlite dataset with 3 features in each later. I've also included the fixtures/fixture_util.py which generated the fixture dataset. My branch has also been rebased with upstream/master with resolved conficts.

@jdroenner jdroenner merged commit 020f578 into georust:master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants