Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TextOptions #223

Closed
wants to merge 13 commits into from
Closed

Remove TextOptions #223

wants to merge 13 commits into from

Conversation

stanciuadrian
Copy link
Contributor

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

Closes #222

lnicola
lnicola reviewed Oct 13, 2021
View reviewed changes
src/raster/rasterize.rs Outdated Show resolved Hide resolved
lnicola
lnicola reviewed Oct 13, 2021
View reviewed changes
src/raster/rasterize.rs Outdated Show resolved Hide resolved
lnicola
lnicola reviewed Oct 13, 2021
View reviewed changes
src/raster/rasterize.rs Outdated Show resolved Hide resolved
@lnicola
Copy link
Member

lnicola commented Oct 13, 2021

Looks nice, let's move CplStringList somewhere else (not sure where, maybe into a new cpl module) to fix the warning, squash the commits and it's good to go.

@lnicola
Copy link
Member

lnicola commented Oct 17, 2021

Ping @stanciuadrian?

@lnicola lnicola mentioned this pull request Oct 17, 2021
Merged
2 tasks
@bors bors bot closed this in 1f0cb96 Oct 19, 2021
@bors bors bot closed this in #225 Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lnicola lnicola lnicola left review comments

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

De-dup CslStringList and TextOptions
2 participants
@stanciuadrian @lnicola