Rename and delete datasets #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnicola
reviewed
Oct 19, 2021
| @@ -50,3 +51,8 @@ pub fn _last_null_pointer_err(method_name: &'static str) -> GdalError { | |||
| msg: last_err_msg, | |||
| } | |||
| } | |||
|
|
|||
| pub fn _path_to_c_string(path: &Path) -> Result<CString> { | |||
| let path_str = path.to_string_lossy(); | |||
There was a problem hiding this comment.
I don't know, I just copied the existing behavior. Is there a better way?
There was a problem hiding this comment.
On Unix, yes, on Windows it's complicated.
lnicola
approved these changes
Oct 19, 2021
|
Looks like there's a conflict, can you rebase? |
|
Looks good, I'll merge it tomorrow unless someone else has remarks. |
|
* for some definition of "tomorrow" bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.The
Driverwas missing the methodsrenameanddelete(and more). I've added them together with a test.I was quite unsure to use
&stror&Pathas input since we use both in our codebase, in particular,&PathforDataset::open. This is why I stuck with&Pathhere. For creating theCStringout of the&Path, I've added a method in util to have a common way to do this.