Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add geometry_type_to_name function #250

Merged
merged 1 commit into from
Jan 29, 2022
Merged

Add geometry_type_to_name function #250

merged 1 commit into from
Jan 29, 2022

Conversation

ttencate
Copy link
Contributor

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

@ttencate ttencate force-pushed the feature/geometry_type_to_name branch from 4c4634c to e63864c Compare January 27, 2022 15:35
@ttencate ttencate force-pushed the feature/geometry_type_to_name branch 3 times, most recently from 667cc7b to 25d6c17 Compare January 29, 2022 11:18
@lnicola
Copy link
Member

lnicola commented Jan 29, 2022

Oof, if you're still around, can you rebase to fix the changelog conflict?

@ttencate ttencate force-pushed the feature/geometry_type_to_name branch from 25d6c17 to 7ba3376 Compare January 29, 2022 11:24
@lnicola
Copy link
Member

lnicola commented Jan 29, 2022

bors r+

bors bot added a commit that referenced this pull request Jan 29, 2022
@bors @ttencate
Merge #250
4c0ff09 
250: Add geometry_type_to_name function r=lnicola a=ttencate

- [x] I agree to follow the project's [code of conduct](https://github.com/georust/gdal/blob/master/CODE_OF_CONDUCT.md).
- [x] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users.
---



Co-authored-by: Thomas ten Cate <[email protected]>
@ttencate
Copy link
Contributor Author

Btw how would you feel about having this awkward OGRwkbGeometryType hammered into a proper Rust enum called GeometryType? Just a matter of someone not having done it yet, or are there objections?

@bors
Copy link
Contributor

bors bot commented Jan 29, 2022

Build failed:

@ttencate
Copy link
Contributor Author

I will run Clippy and rustfmt before pushing next time. I will run Clippy and rustfmt before pushing next time. I will run Clippy and rustfmt before pushing next time.

@ttencate ttencate force-pushed the feature/geometry_type_to_name branch from 7ba3376 to 54f8e74 Compare January 29, 2022 11:27
@lnicola
Copy link
Member

lnicola commented Jan 29, 2022

bors r+

@lnicola
Copy link
Member

lnicola commented Jan 29, 2022

Btw how would you feel about having this awkward OGRwkbGeometryType hammered into a proper Rust enum called GeometryType? Just a matter of someone not having done it yet, or are there objections?

Might be a good idea, but I'm not sure how extensible it's supposed to be (take a look at the values defined in GDAL).

@bors
Copy link
Contributor

bors bot commented Jan 29, 2022

Build succeeded:

@bors bors bot merged commit 8d347ba into georust:master Jan 29, 2022
@ttencate ttencate deleted the feature/geometry_type_to_name branch February 1, 2022 12:17
@ttencate ttencate mentioned this pull request Feb 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lnicola lnicola lnicola left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ttencate @lnicola