Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ffi into a seperate crate. #26

Merged
merged 2 commits into from
Jan 2, 2017
Merged

Conversation

jdroenner
Copy link
Member

#25: moved ffi to a new crate: gdal-sys.
I also added a cargo workspace where the rust-gdal crate is the root and gdal-sys is a member.

- added a cargo workspace.
@frewsxcv
Copy link
Member

It looks like Travis found some errors when running cargo test. Some of the imports might need to be changed within mod test?

@jdroenner
Copy link
Member Author

It appears that the problem is use gdal_sys::gdal; in the raster mod and use gdal_sys::ogr; in the vector mod.
I'm using use raster::{gdal, Driver, RasterBand}; in the other source files of the module which works with the nightly version of rust but not in stable and beta. What is the correct behavior? Using pub use ... in the module works fine with beta and stable but i don't think that the ffi should be public in rust-gdal.

I will put use gdal_sys::gdal; and use gdal_sys::ogr; directly into the source files to fix this.

@frewsxcv frewsxcv self-requested a review December 29, 2016 04:48
@jdroenner jdroenner merged commit 4098e24 into georust:master Jan 2, 2017
@jdroenner jdroenner deleted the gdal-sys2 branch January 2, 2017 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants