-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrapper for gdalmdimtranslate #289
Conversation
src/programs/raster/mdimtranslate.rs
Outdated
impl TryFrom<Vec<&str>> for MultiDimTranslateOption { | ||
type Error = GdalError; | ||
|
||
fn try_from(value: Vec<&str>) -> std::result::Result<Self, Self::Error> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work?
fn try_from(value: Vec<&str>) -> std::result::Result<Self, Self::Error> { | |
fn try_from(value: Vec<&str>) -> Result<Self> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/programs/raster/mdimtranslate.rs
Outdated
/// | ||
/// [GDALMultiDimTranslateOptions]: https://gdal.org/api/gdal_utils.html#_CPPv428GDALMultiDimTranslateOptions | ||
/// | ||
pub struct MultiDimTranslateOption { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably be called MultiDimTranslateOptions
, since there can be multiple options inside.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to replace the |
bors r+ |
289: wrapper for gdalmdimtranslate r=lnicola a=ChristianBeilschmidt - [X] I agree to follow the project's [code of conduct](https://github.com/georust/gdal/blob/master/CODE_OF_CONDUCT.md). - [X] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users. --- I created a wrapper around `GDALMultiDimTranslate`. I used part of the logic for the wrapper for the VRT program. Co-authored-by: Christian Beilschmidt <[email protected]>
Build failed: |
Is this some sort of new GDAL warning? |
Since it appeared in the LTS-CI, I guess not. What could have happened: I'm not sure, but we could get races on all the global stuff. What do you think? |
bors merge |
Build succeeded: |
I'm a bit worried about the test failure here. |
i guess the problem is not really related to this PR but to gdal and cargo test in general. Cargo runs all the tests in parallel and when two tests fail at the same time we have a problem with global state. |
I think we can move them to an integration test. |
297: Move error handling test to an integration test r=jdroenner a=lnicola - [x] I agree to follow the project's [code of conduct](https://github.com/georust/gdal/blob/master/CODE_OF_CONDUCT.md). - [x] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users. --- CC #289 (comment) Co-authored-by: Laurențiu Nicola <[email protected]>
CHANGES.md
if knowledge of this change could be valuable to users.I created a wrapper around
GDALMultiDimTranslate
. I used part of the logic for the wrapper for the VRT program.