Enabled non-consuming fallible conversion from GDAL to geo-types Geometry #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ypes Geometry. Added `to_geo` method, symmetric to the method `to_gdal` from `ToGdal`.
Fixed CHANGES.md conflict.
lnicola
reviewed
Sep 2, 2022
src/vector/gdal_to_geo.rs
Outdated
| impl TryFrom<Geometry> for geo_types::Geometry<f64> { | ||
| type Error = GdalError; | ||
| fn try_from(value: Geometry) -> Result<Self, Self::Error> { | ||
| TryFrom::<&Geometry>::try_from(&value) |
There was a problem hiding this comment.
Suggested change
| TryFrom::<&Geometry>::try_from(&value) | |
| Self::try_from(&value) |
There was a problem hiding this comment.
Is my suggestion somehow wrong?
I'm a bit confused, you 👍ed it, marked it as resolved, but didn't change the code.
There was a problem hiding this comment.
@lnicola I forgot to push 🤦 . I'm recovering from The Covid, and not only forgot to push, but did the "resolved" in the wrong order. My apologies.
There was a problem hiding this comment.
No worries, and good luck with your recovery!
…to_geo * commit '604c41fbf62b96d0b44a14606b6f83b37db8059e': (29 commits) (cargo-release) version 0.13.0 (cargo-release) version 0.7.0 bump changelog version use `TempFixture` for rasterband get_statistics test test util with `TempFixture` changelog entry use tempfiles to not access file multiple times Require matching data types in MDArray::read_into_slice wrap test in inner block to remove some drops Update src/raster/mdarray.rs Move error handling test to an integration test changelog entry enforce that GdalError is `Send` added changes to CHANGES.md get_statistics for rasterbands and md rasters remove uses of `addr_of_mut` make unsafe regions smaller fixed wrong error method name more convenience functions allow empty dimensions ...
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added
Geometry::to_geomethod, for symmetry withToGdal::to_gdal.CHANGES.mdif knowledge of this change could be valuable to users.Closes #276