Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't derive Clone, PartialEq and Eq for ExtendedDataType #451

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Oct 4, 2023

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

Fixes #449

@lnicola lnicola force-pushed the extended-data-type-no-clone-eq branch from cbbd671 to b585c6e Compare October 4, 2023 13:27
@lnicola
Copy link
Member Author

lnicola commented Oct 4, 2023

r? @metasim

Sorry if you wanted to take this one, I just had it laying around from earlier.

@metasim
Copy link
Contributor

metasim commented Oct 4, 2023

Sorry if you wanted to take this one

😆 No. Not really. Thank you! 🙇

@metasim
Copy link
Contributor

metasim commented Oct 4, 2023

bors r+

@metasim metasim self-requested a review October 4, 2023 15:16
@bors
Copy link
Contributor

bors bot commented Oct 4, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 57db2d3 into georust:master Oct 4, 2023
@lnicola lnicola deleted the extended-data-type-no-clone-eq branch October 4, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ExtendedDataType improperly implements Clone
2 participants