Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove chrono dependency #57

Closed
wants to merge 2 commits into from
Closed

Remove chrono dependency #57

wants to merge 2 commits into from

Conversation

flosse
Copy link
Contributor

@flosse flosse commented Jul 18, 2022

... and instead of binding the user to a specific time library, the UnixTime should be converted by the user depending on the use case.

uklotzde
uklotzde reviewed Jul 18, 2022
View reviewed changes
src/opencage.rs Outdated Show resolved Hide resolved
@flosse flosse mentioned this pull request Aug 29, 2022
Open
2 tasks
@lnicola
Copy link
Member

lnicola commented Feb 13, 2023

r? @urschrei

@lnicola
Copy link
Member

lnicola commented Feb 14, 2023

bors r=urschrei,lnicola

@lnicola
Copy link
Member

lnicola commented Feb 14, 2023

bors r-

bors bot added a commit that referenced this pull request Feb 14, 2023
@bors @flosse
Merge #57
27463de 
57: Remove unmentained chrono dependency r=urschrei,lnicola a=flosse

... and instead of binding the user to a specific time library, the `UnixTime` should be converted by the user depending on the use case.

Co-authored-by: Markus Kohlhase <[email protected]>
@bors
Copy link
Contributor

bors bot commented Feb 14, 2023

Canceled.

lnicola
lnicola reviewed Feb 14, 2023
View reviewed changes
CHANGES.md Outdated Show resolved Hide resolved
@flosse flosse changed the title Remove unmentained chrono dependency Remove chrono dependency Mar 14, 2023
@lnicola
Copy link
Member

lnicola commented Mar 14, 2023

bors r=urschrei,lnicola

bors bot added a commit that referenced this pull request Mar 14, 2023
@bors @flosse
Merge #57
e77a7ac 
57: Remove chrono dependency r=urschrei,lnicola a=flosse

... and instead of binding the user to a specific time library, the `UnixTime` should be converted by the user depending on the use case.

Co-authored-by: Markus Kohlhase <[email protected]>
@bors
Copy link
Contributor

bors bot commented Mar 14, 2023

Build failed:

@urschrei
Copy link
Member

this version of Cargo is older than the 2021 edition, and only supports 2015 and 2018 editions.

@urschrei
Copy link
Member

urschrei commented Mar 14, 2023 •
edited
Loading

I'm gonna push a fix separately (use same rust versions as geo) so we can get this show on the road.

@urschrei
Copy link
Member

bors retry

bors bot added a commit that referenced this pull request Mar 14, 2023
@bors @flosse
Merge #57
6b07fa1 
57: Remove chrono dependency r=urschrei,lnicola a=flosse

... and instead of binding the user to a specific time library, the `UnixTime` should be converted by the user depending on the use case.

Co-authored-by: Markus Kohlhase <[email protected]>
@bors
Copy link
Contributor

bors bot commented Mar 14, 2023

Build failed:

@urschrei
Copy link
Member

now what

@urschrei
Copy link
Member

Ah, these are actual test failures.

@flosse
Copy link
Contributor Author

flosse commented Apr 18, 2023

Ah, these are actual test failures.

What's the status of this? Can I help?

@lnicola
Copy link
Member

lnicola commented Apr 18, 2023 •
edited
Loading

I think the latest failed run is https://github.com/georust/geocoding/actions/runs/4416893986/jobs/7741822915. Maybe some API changed a little?

@flosse
Copy link
Contributor Author

flosse commented Apr 18, 2023

🤔 It seems to be independent of this PR.

@lnicola
Copy link
Member

lnicola commented Apr 18, 2023

Indeed. Without looking at the code, I'd guess that one or more external APIs changed.

@flosse
Copy link
Contributor Author

flosse commented Apr 18, 2023

Just rebased on current master

@lnicola
Copy link
Member

lnicola commented Apr 18, 2023

I think GitHub is having a bad day, but...

bors retry

bors bot added a commit that referenced this pull request Apr 18, 2023
@bors @flosse
Merge #57
f36edfc 
57: Remove chrono dependency r=urschrei,lnicola a=flosse

... and instead of binding the user to a specific time library, the `UnixTime` should be converted by the user depending on the use case.

Co-authored-by: Markus Kohlhase <[email protected]>
@bors
Copy link
Contributor

bors bot commented Apr 18, 2023

Canceled.

@flosse
Copy link
Contributor Author

flosse commented Apr 18, 2023

I fixed the clippy lints but a lot of tests are failing locally.

@flosse
Copy link
Contributor Author

flosse commented Apr 18, 2023

.. last successful CI build was while ago: 1736b26

@lnicola
Copy link
Member

lnicola commented Apr 18, 2023

Yeah, I'm afraid it's broken :(.

@lnicola
Copy link
Member

lnicola commented Jun 15, 2023

bors retry

@bors
Copy link
Contributor

bors bot commented Jun 15, 2023

Merge conflict.

@michaelkirk michaelkirk mentioned this pull request Jul 11, 2023
Merged
2 tasks
@michaelkirk
Copy link
Member

Merge conflict.

Rebased and conflicts addresses with #60

@michaelkirk
Copy link
Member

Superseded by #60

@michaelkirk michaelkirk closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uklotzde uklotzde uklotzde left review comments

@lnicola lnicola lnicola left review comments

@urschrei urschrei urschrei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@flosse @lnicola @urschrei @michaelkirk @uklotzde