Skip to content

Commit

Permalink
Add comments to disabled tests
Browse files Browse the repository at this point in the history
  • Loading branch information
pka committed Aug 29, 2024
1 parent 63475db commit 3477741
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
7 changes: 5 additions & 2 deletions geozero/tests/geozero-api.rs
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ fn max_height_finder() -> Result<()> {
}

/*
// Broken: this example does work with Flatgeobuf, but not GeoJson
// Disabled, since we don't want to have a circular dependency between flatgeobuf and geozero
struct FeatureFinder;
impl PropertyProcessor for FeatureFinder {
Expand All @@ -81,10 +84,10 @@ fn feature_finder() -> Result<()> {
let mut json = GeoJsonLineReader::new(&mut filein);
let mut finder = FeatureFinder {};
// process_properties is not public. We should have iterators!
// process_properties is not public. We should feature have iterators for all `GeozeroDatasource`s!
// json.process_properties(&mut finder);
//
// Using FbgReader:
// Using FgbReader:
// while let Some(feature) = fgb.next()? {
// let found = feature.process_properties(&mut finder);
// if found.is_err() || found.unwrap() {
Expand Down
4 changes: 4 additions & 0 deletions geozero/tests/svg.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ fn json_to_svg() -> Result<()> {
}

/*
// FlatgeoBuf to SVG conversion
// Disabled, since we don't want to have a circular dependency between flatgeobuf and geozero
use flatgeobuf::{FgbReader, Header};
use geozero::svg::SvgWriter;
use seek_bufread::BufReader;
Expand Down

0 comments on commit 3477741

Please sign in to comment.