Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: parsing Folder and Document sibling elements #19

Merged
merged 1 commit into from
Jan 23, 2022
Merged

fix: parsing Folder and Document sibling elements #19

merged 1 commit into from
Jan 23, 2022

Conversation

pjsier
Copy link
Member

@pjsier pjsier commented Jan 21, 2022

Closes #18. Because Kml::Folder and Kml::Document parsing is recursively calling read_elements we need to handle Event::End and break if the closing tag matches either of those. Otherwise sibling Folder or Document elements will end up with the first sibling containing the other

@pjsier pjsier mentioned this pull request Jan 21, 2022
Closed
@pjsier pjsier merged commit d753a71 into main Jan 23, 2022
@pjsier pjsier deleted the fix/folder-sibling-parsing branch January 23, 2022 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nested folders
1 participant
@pjsier