Fix UTF-8 decoding errors #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjsier
force-pushed
the
fix/utf8-decoding
branch
from
2ca4e55 to
6c4767b
Compare
pjsier
force-pushed
the
fix/utf8-decoding
branch
from
6c4767b to
69ddbfe
Compare
michaelkirk
approved these changes
Mar 6, 2021
michaelkirk
reviewed
Mar 6, 2021
| element.content = Some(e.unescape_and_decode(&self.reader).expect("Error")) | ||
| element.content = Some( | ||
| e.unescape_and_decode(&self.reader) | ||
| .unwrap_or_else(|_| String::from_utf8_lossy(e.escaped()).to_string()), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1. Currently any issues with UTF-8 decoding cause a panic, so this adds a fallback to
from_utf8_lossyinstead of callingexpect