Fix AABB::from_points which relied on implementation details of AABB::new_empty #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…:new_empty This method does not just need an empty AABB, but actually requires that the lower/upper corners use max/min values of the point coordinates. This change therefore open-codes this to keep these invariants and the code that relies on them close together.
urschrei
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rstar/CHANGELOG.mdif knowledge of this change could be valuable to users.This method does not just need an empty AABB, but actually requires that the lower/upper corners use max/min values of the point coordinates.
This change therefore open-codes this to keep these invariants and the code that relies on them close together.
A changelog entry should not be necessary as we luckily did not yet release the regression.
Closes #170