Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Center and Bounds structs #13

Merged
merged 1 commit into from
May 18, 2022
Merged

add Center and Bounds structs #13

merged 1 commit into from
May 18, 2022

Conversation

nyurik
Copy link
Member

@nyurik nyurik commented May 18, 2022

  • fix incorrectly declared center field to use Center struct
  • add Center and Bounds structs

fixes #11

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

@nyurik nyurik requested a review from stepankuzmin May 18, 2022 15:29
@nyurik
add Center and Bounds structs
118bc8f 
* fix incorrectly declared center field to use `Center` struct
* add `Center` and `Bounds` structs
* use f64 for all values
stepankuzmin
stepankuzmin approved these changes May 18, 2022
View reviewed changes
Copy link
Collaborator

@stepankuzmin stepankuzmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@nyurik nyurik merged commit d9e997b into georust:main May 18, 2022
@nyurik nyurik deleted the center branch May 18, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stepankuzmin stepankuzmin stepankuzmin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect center field type
2 participants
@nyurik @stepankuzmin