Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tilejson! macro for instantiation, refactor #16

Merged
merged 3 commits into from
May 25, 2022
Merged

Conversation

nyurik
Copy link
Member

@nyurik nyurik commented May 25, 2022

  • tilejson! solves most of the weirdness left-over from the builder pattern, and allows flexible usage (see docs)
  • fix docs and add it to CI
  • move structs into separate files
  • implement FromStr for the Bounds and Center structs
  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

* `tilejson!` solves most of the weirdness left-over from the builder pattern, and allows flexible usage (see docs)
* fix docs and add it to CI
* move structs into separate files
@nyurik nyurik requested a review from stepankuzmin May 25, 2022 03:11
Copy link
Collaborator

@stepankuzmin stepankuzmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nyurik nyurik merged commit f787a8f into georust:main May 25, 2022
@nyurik nyurik deleted the rfctr branch May 25, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants