Make Bounds::try_from() more generic
#18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyurik
force-pushed
the
slice
branch
2 times, most recently
from
308641a to
cd97a40
Compare
nyurik
changed the title
Bounds::try_from() more genericBounds::try_from() more generic
* Add `Bounds::from` for `[f64; 4]`, `[f32; 4]`, `[i32; 4]` * Add `Bounds::try_from` now also supports `&[f64]`, `&[f32]`, `&[i32]` in addition to `Vec<f64>` * Simplify CI scripts, reducing the number of external dependencies * Reworked `Bounds` string parsing
stepankuzmin
approved these changes
Oct 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bounds::fromfor[f64; 4],[f32; 4],[i32; 4]Bounds::try_fromnow also supports&[f64],&[f32],&[i32]in addition toVec<f64>Boundsstring parsingCHANGES.mdif knowledge of this change could be valuable to users.