Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bounds MAX, MAX_TILED, Add, AddAssign #19

Merged
merged 1 commit into from
May 29, 2022
Merged

Conversation

nyurik
Copy link
Member

@nyurik nyurik commented May 29, 2022

  • Add Bounds::MAX to create a maximum -180..180, -90..90 value.
  • Add Bounds::MAX_TILED to create a maximum allowed for vector tiles per spec.
  • Implement Add and AddAssign on Bounds
  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

* Add `Bounds::MAX` to create a maximum -180..180, -90..90 value.
* Add `Bounds::MAX_TILED` to create a maximum allowed for vector tiles per spec.
* Implement `Add` and `AddAssign` on `Bounds`
@nyurik nyurik requested a review from stepankuzmin May 29, 2022 03:07
Copy link
Collaborator

@stepankuzmin stepankuzmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nyurik nyurik merged commit 1f9c310 into georust:main May 29, 2022
@nyurik nyurik deleted the max-add branch May 29, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants