Fmt, Clippy, CI to match other georust proj #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyurik
force-pushed
the
lint
branch
2 times, most recently
from
7ef1d50 to
0749f84
Compare
nyurik
force-pushed
the
lint
branch
4 times, most recently
from
05a54f1 to
35d334d
Compare
2 tasks
Please rename the primary branch to `main` for consistency. Similar to other georust projects, make CI: * go through additional fmt and clippy validation * run on pull requests, but ignore non-standard branches (it is usually easier to submit PRs from personal forks, but some maintainers may do it from the primary repo) * run fmt and clippy * add `TileJSONBuilder::default()` * ignore intellij files Minor cleanup: * use `.to_string()` everywhere for consistency * use Self when possible * remove `serde_json` dependency * use 2021 edition Also, get rid of the custom `cargo-all-features` as it is not really needed, so using the KISS principle :)
|
Note that |
stepankuzmin
approved these changes
May 18, 2022
There was a problem hiding this comment.
Hey @nyurik 👋
Thanks for the PR, it looks good to me. Unfortunately, I don't have the permission to rename the default branch to main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please rename the primary branch to
mainfor consistency.Similar to other georust projects, make CI:
TileJSONBuilder::default()Minor cleanup:
.to_string()everywhere for consistencyserde_jsondependencyAlso, get rid of the custom
cargo-all-featuresas it is not really needed, so using the KISS principle :)CHANGES.mdif knowledge of this change could be valuable to users.