Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove src/Shared/NcdfUtil/perl folder #183

Merged
merged 2 commits into from
Feb 9, 2023

Conversation

yantosca
Copy link
Contributor

@yantosca yantosca commented Dec 15, 2022

This PR does the following:

  1. Removes the src/Shared/NcdfUtil/perl folder, which contained copies of isCoards, nc_chunk.pl, as well as some obsolete netCDF scripts. Now that we have created the new https://github.com/geoschem/netcdf-scripts folder, we no longer need to keep these scripts within the GEOS-Chem code. GEOS-Chem and HEMCO users should look to the netcdf-scripts repo for the most recent versions of netCDF utility scripts.

  2. Adds a src/Shared/NcdfUtil/README.md file.

src/Shared/NcdfUtil/README.md
- Added a readme describing contents of this folder.  Also now directs
  users to the https://github.com/geoschem/netcdf-scripts repository
  where isCoards, nc_chunk.pl, etc. scripts are now maintained.

src/Shared/NcdfUtil/perl/
- Removed this folder

Signed-off-by: Bob Yantosca <[email protected]>
@yantosca yantosca added category: Feature Request New feature or request topic: Structural Modifications Related to HEMCO structural modifications (as opposed to scientific updates) no-diff-to-benchmark This update will have no impact on benchmark simulations labels Dec 15, 2022
@yantosca yantosca requested a review from msulprizio December 15, 2022 21:44
@yantosca yantosca self-assigned this Dec 15, 2022
@yantosca
Copy link
Contributor Author

yantosca commented Dec 15, 2022

See companion PR geoschem/geos-chem#1567

@yantosca yantosca modified the milestones: 3.7.0, 3.5.2 Dec 15, 2022
@yantosca
Copy link
Contributor Author

Also tagging @jimmieln

@jimmielin
Copy link
Collaborator

Thanks Bob! The new netcdf-scripts repository will be very useful, thanks for letting me know about it.

@yantosca
Copy link
Contributor Author

Integration tests pending

This brings the HEMCO 3.6.0 updates into feature/delete-nc-scripts,
which had been much further behind.

Signed-off-by: Bob Yantosca <[email protected]>
@yantosca
Copy link
Contributor Author

I have merged this up to HEMCO 3.6.0. Integration tests pending.

@yantosca
Copy link
Contributor Author

I have brought this PR up to HEMCO 3.6.0 and have resubmitted the integration tests. All GEOS-Chem Classic integration tests (with this HEMCO update) passed:

==============================================================================
GEOS-Chem Classic: Execution Test Results

Using 24 OpenMP threads
Number of execution tests: 51
==============================================================================
 
Execution tests:
------------------------------------------------------------------------------
gc_025x03125_CH4_geosfp_47L_na......................Execute Simulation....PASS
gc_025x03125_fullchem_geosfp_47L_na.................Execute Simulation....PASS
gc_05x0625_CH4_merra2_47L_na........................Execute Simulation....PASS
gc_05x0625_fullchem_merra2_47L_na...................Execute Simulation....PASS
gc_2x25_aerosol_merra2..............................Execute Simulation....PASS
gc_2x25_carbon_merra2...............................Execute Simulation....PASS
gc_2x25_CH4_merra2..................................Execute Simulation....PASS
gc_2x25_CO2_merra2..................................Execute Simulation....PASS
gc_2x25_fullchem_merra2.............................Execute Simulation....PASS
gc_2x25_Hg_merra2...................................Execute Simulation....PASS
gc_2x25_metals_merra2...............................Execute Simulation....PASS
gc_2x25_POPs_BaP_merra2.............................Execute Simulation....PASS
gc_2x25_tagCH4_merra2...............................Execute Simulation....PASS
gc_2x25_tagCO_merra2................................Execute Simulation....PASS
gc_2x25_tagO3_merra2................................Execute Simulation....PASS
gc_2x25_TransportTracers_merra2.....................Execute Simulation....PASS
gc_2x25_TransportTracers_merra2_LuoWd...............Execute Simulation....PASS
gc_4x5_aerosol_geosfp...............................Execute Simulation....PASS
gc_4x5_aerosol_merra2...............................Execute Simulation....PASS
gc_4x5_carbon_geosfp................................Execute Simulation....PASS
gc_4x5_carbon_merra2................................Execute Simulation....PASS
gc_4x5_CH4_geosfp...................................Execute Simulation....PASS
gc_4x5_CH4_merra2...................................Execute Simulation....PASS
gc_4x5_fullchem_aciduptake_merra2...................Execute Simulation....PASS
gc_4x5_fullchem_APM_merra2..........................Execute Simulation....PASS
gc_4x5_fullchem_benchmark_merra2....................Execute Simulation....PASS
gc_4x5_fullchem_complexSOA_merra2...................Execute Simulation....PASS
gc_4x5_fullchem_complexSOA_SVPOA_merra2.............Execute Simulation....PASS
gc_4x5_fullchem_geosfp..............................Execute Simulation....PASS
gc_4x5_fullchem_marinePOA_merra2....................Execute Simulation....PASS
gc_4x5_fullchem_merra2..............................Execute Simulation....PASS
gc_4x5_fullchem_merra2_47L..........................Execute Simulation....PASS
gc_4x5_fullchem_merra2_LuoWd........................Execute Simulation....PASS
gc_4x5_fullchem_RRTMG_merra2........................Execute Simulation....PASS
gc_4x5_fullchem_TOMAS15_merra2_47L..................Execute Simulation....PASS
gc_4x5_fullchem_TOMAS40_merra2_47L..................Execute Simulation....PASS
gc_4x5_Hg_geosfp....................................Execute Simulation....PASS
gc_4x5_Hg_merra2....................................Execute Simulation....PASS
gc_4x5_metals_merra2................................Execute Simulation....PASS
gc_4x5_POPs_BaP_geosfp..............................Execute Simulation....PASS
gc_4x5_POPs_BaP_merra2..............................Execute Simulation....PASS
gc_4x5_tagCH4_geosfp................................Execute Simulation....PASS
gc_4x5_tagCH4_merra2................................Execute Simulation....PASS
gc_4x5_tagCO_geosfp.................................Execute Simulation....PASS
gc_4x5_tagCO_merra2.................................Execute Simulation....PASS
gc_4x5_tagO3_geosfp.................................Execute Simulation....PASS
gc_4x5_tagO3_merra2.................................Execute Simulation....PASS
gc_4x5_TransportTracers_geosfp......................Execute Simulation....PASS
gc_4x5_TransportTracers_geosfp_LuoWd................Execute Simulation....PASS
gc_4x5_TransportTracers_merra2......................Execute Simulation....PASS
gc_4x5_TransportTracers_merra2_LuoWd................Execute Simulation....PASS
 
Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 51
Execution tests failed: 0
Execution tests not yet completed: 0

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

As did all of the GCHP integration tests (with this HEMCO update)

==============================================================================
GCHP: Execution Test Results

Number of execution tests: 3
==============================================================================
 
Execution tests:
------------------------------------------------------------------------------
gchp_fullchem_benchmark_merra2_c48...............Execute Simulation.....PASS
gchp_fullchem_standard_merra2_c24................Execute Simulation.....PASS
gchp_TransportTracers_geosfp_c24.................Execute Simulation.....PASS
 
Summary of execution test results:
------------------------------------------------------------------------------
Execution tests passed:        3
Execution tests failed:        0
Execution tests not completed: 0

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

@yantosca
Copy link
Contributor Author

yantosca commented Feb 8, 2023

@msulprizio: Since we have already merged the logfile updates into GC and HEMCO, I think it's OK if this PR goes into GEOS-Chem 14.2.0 and HEMCO 3.7.0. Otherwise I'd have to make a HEMCO 3.6.1 version.

Copy link
Contributor

@msulprizio msulprizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a simple PR removing files in the src/Shared/NcdfUtil/perl directory and adding a README.md file. Good to merge.

@msulprizio msulprizio merged commit da09830 into dev/3.7.0 Feb 9, 2023
@msulprizio msulprizio deleted the feature/delete-nc-scripts branch February 9, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Feature Request New feature or request no-diff-to-benchmark This update will have no impact on benchmark simulations topic: Structural Modifications Related to HEMCO structural modifications (as opposed to scientific updates)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants